Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#528): allow roundup group users to interact with git repos #530

Merged
merged 5 commits into from
Dec 5, 2024
Merged

feat(#528): allow roundup group users to interact with git repos #530

merged 5 commits into from
Dec 5, 2024

Conversation

JacobCoffee
Copy link
Member

Description

  • Adds group write bit for cloned repos

Closes

@JacobCoffee
Copy link
Member Author

@ewdurbin wdyt? will this be sufficient or did I misunderstand maybe?

@ewdurbin
Copy link
Member

I'm not entirely sure. The goal is that the following would work without error, note that rouilj is a member of the roundup group.

ee@bugs:~$ sudo su - rouilj 
rouilj@bugs:/srv/roundup/trackers/cpython$ groups
rouilj psf-admin roundup
rouilj@bugs:~$ cd /srv/roundup/trackers/cpython/
rouilj@bugs:/srv/roundup/trackers/cpython$ git status
fatal: detected dubious ownership in repository at '/srv/roundup/trackers/cpython'
To add an exception for this directory, call:

	git config --global --add safe.directory /srv/roundup/trackers/cpython

This should be reproducible locally for verification.

@ewdurbin
Copy link
Member

ewdurbin commented Dec 3, 2024

Testing, it doesn't look like this resolves the issue when bringing up the service locally.

@JacobCoffee JacobCoffee force-pushed the 528-enhance-roundup-group-perms branch from 69be1e5 to ac2f2ac Compare December 4, 2024 19:23
@JacobCoffee
Copy link
Member Author

This seems to work–I misunderstood what was needing done

vagrant@bugs:~$ sudo su coffee
coffee@bugs:/home/vagrant$ sudo su - rouilj 
rouilj@bugs:~$ cd /srv/roundup/trackers/cpython/
rouilj@bugs:/srv/roundup/trackers/cpython$ git status
On branch master
Your branch is up to date with 'origin/master'.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        config.ini
        detectors/config.ini
        django-gae2django/
        rietveld/
        scripts/suggest.pyc
        wsgi.py
        wsgi.pyc

nothing added to commit but untracked files present (use "git add" to track)
rouilj@bugs:/srv/roundup/trackers/cpython$ cat /etc/gitconfig 
# TRACKER-cpython-START
[safe]
directory = /srv/roundup/trackers/cpython
# TRACKER-cpython-END
# TRACKER-jython-START
[safe]
directory = /srv/roundup/trackers/jython
# TRACKER-jython-END
# TRACKER-roundup-START
[safe]
directory = /srv/roundup/trackers/roundup
# TRACKER-roundup-END

ewdurbin
ewdurbin approved these changes Dec 5, 2024
View reviewed changes
Copy link
Member

@ewdurbin ewdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go once the linting passes!

@JacobCoffee JacobCoffee merged commit 2d16f11 into main Dec 5, 2024
2 checks passed
@JacobCoffee JacobCoffee deleted the 528-enhance-roundup-group-perms branch December 5, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewdurbin ewdurbin ewdurbin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow roundup group to interact with tracker config clones set by Salt
2 participants
@JacobCoffee @ewdurbin